Move user role assignment on registration to UserServiceObserver

Changelog

@@ -1,4 +1,5 @@
 2019-02-21 DariusIII
+	* Chg: Move user role assignment on registration to UserServiceObserver
 	* Chg: Update ocramius/package-versions to version 1.4.0
 	* Chg: Update tinymce to version 5.0.1
 	* Chg: Purge accounts that have not logged in and don't have api access for more than 6 months, daily

app/Http/Controllers/Auth/RegisterController.php

@@ -69,10 +69,6 @@ class RegisterController extends Controller
             'userseed' => md5(Str::uuid()->toString()),
         ]);
 
-        $roleName = Role::query()->where('id', $data['roles_id'])->value('name');
-
-        $user->assignRole($roleName);
-
         return $user;
     }
 

app/Observers/UserServiceObserver.php

@@ -7,6 +7,7 @@ use App\Jobs\SendWelcomeEmail;
 use App\Jobs\SendAccountDeletedEmail;
 use App\Jobs\SendNewRegisteredAccountMail;
 use Jrean\UserVerification\Facades\UserVerification;
+use Spatie\Permission\Models\Role;
 
 class UserServiceObserver
 {
@@ -20,6 +21,8 @@ class UserServiceObserver
      */
     public function created(User $user)
     {
+        $roleName = Role::query()->where('id', $user->roles_id)->value('name');
+        $user->assignRole($roleName);
         SendNewRegisteredAccountMail::dispatch($user);
         SendWelcomeEmail::dispatch($user);
         UserVerification::generate($user);