Replace all of getById functions with Model::find

This commit is contained in:
DariusIII
2018-02-02 11:36:13 +01:00
parent 54b26cfd70
commit 3ccdbc7e6c
12 changed files with 15 additions and 29 deletions
+1
View File
@@ -1,4 +1,5 @@
2018-02-02 DariusIII
* Chg: Replace all of getById functions with Model::find
* Fix: Fix getByIdAndRssToken function
* Chg: Use replace getById user lookup with User model find built in function(does the same thing as custom function)
2018-02-01 DariusIII
-15
View File
@@ -325,21 +325,6 @@ class Category extends Model
->get(['id']);
}
/**
* Get a category row by its id.
*
*
* @param $id
* @return \Illuminate\Database\Eloquent\Model|null|static
*/
public static function getById($id)
{
return self::query()
->with('parent')
->where('id', $id)
->first();
}
/**
* Get multiple categories.
*
+1 -1
View File
@@ -1098,7 +1098,7 @@ class Releases
{
// Get the category for the parent of this release.
$currRow = Release::getCatByRelId($currentID);
$catRow = Category::getById($currRow['categories_id']);
$catRow = Category::find($currRow['categories_id']);
$parentCat = $catRow['parentid'];
$results = $this->search(
+1 -1
View File
@@ -21,7 +21,7 @@ switch ($action) {
if (isset($_GET['id'])) {
$page->title = 'Category Edit';
$id = $_GET['id'];
$cat = Category::getById($id);
$cat = Category::find($id);
$page->smarty->assign('category', $cat);
}
break;
+1 -1
View File
@@ -37,7 +37,7 @@ switch ($action) {
];
if (isset($_GET['id'])) {
$id = $_GET['id'];
$menuRow = Menu::getById($id);
$menuRow = Menu::find($id);
}
$page->title = 'Menu Edit';
$page->smarty->assign('menu', $menuRow);
+1 -1
View File
@@ -65,7 +65,7 @@ $page->smarty->assign('pager', $pager);
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {
+2 -2
View File
@@ -47,10 +47,10 @@ $pager = $page->smarty->fetch('pager.tpl');
$page->smarty->assign('pager', $pager);
$covgroup = '';
if ($category === -1 && (int) $grp === -1) {
if ((int) $category === -1 && (int) $grp === -1) {
$page->smarty->assign('catname', 'All');
} elseif ((int) $category !== -1 && (int) $grp === -1) {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
if ($cdata['parentid'] === Category::GAME_ROOT || $cdata['id'] === Category::GAME_ROOT) {
+1 -1
View File
@@ -76,7 +76,7 @@ $page->smarty->assign('pager', $pager);
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {
+2 -2
View File
@@ -81,10 +81,10 @@ $page->smarty->assign('pagerquerysuffix', '#results');
$pager = $page->smarty->fetch('pager.tpl');
$page->smarty->assign('pager', $pager);
if ($category == -1) {
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {
+2 -2
View File
@@ -86,10 +86,10 @@ $page->smarty->assign('pagerquerysuffix', '#results');
$pager = $page->smarty->fetch('pager.tpl');
$page->smarty->assign('pager', $pager);
if ($category == -1) {
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {
+2 -2
View File
@@ -73,10 +73,10 @@ $page->smarty->assign('pagerquerysuffix', '#results');
$pager = $page->smarty->fetch('pager.tpl');
$page->smarty->assign('pager', $pager);
if ($category == -1) {
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {
+1 -1
View File
@@ -65,7 +65,7 @@ $page->smarty->assign('pager', $pager);
if ((int) $category === -1) {
$page->smarty->assign('catname', 'All');
} else {
$cdata = Category::getById($category);
$cdata = Category::find($category);
if ($cdata) {
$page->smarty->assign('catname', $cdata->parent !== null ? $cdata->parent->title.' > '.$cdata->title : $cdata->title);
} else {