starred/esx_core-esx-framework
1
0
Fork 0
mirror of https://github.com/esx-framework/esx_core.git synced 2026-08-29 04:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(society): Correct getOnlinePlayers behaviour

Browse Source 
Actually prevent multiple loops from running at once
This commit is contained in:
Linden
2021-07-05 18:02:45 +10:00
parent ac5e7256de
commit e286bc8602
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
[esx_addons]/esx_society/server/main.lua
+7 -3
View File
@@ -316,9 +316,9 @@ ESX.RegisterServerCallback('esx_society:setJobSalary', function(source, cb, job,
end
end)
local getOnlinePlayers, onlinePlayers = false, nil
local getOnlinePlayers, onlinePlayers = false, {}
ESX.RegisterServerCallback('esx_society:getOnlinePlayers', function(source, cb)
if getOnlinePlayers ~= true then -- Prevent multiple xPlayer loops from running in quick succession
if getOnlinePlayers == false and next(onlinePlayers) == nil then -- Prevent multiple xPlayer loops from running in quick succession
getOnlinePlayers, onlinePlayers = true, {}
local xPlayers = ESX.GetExtendedPlayers()
@@ -330,9 +330,13 @@ ESX.RegisterServerCallback('esx_society:getOnlinePlayers', function(source, cb)
job = xPlayer.job
})
end
cb(onlinePlayers)
getOnlinePlayers = false
Citizen.Wait(1000) -- For the next second any extra requests will receive the cached list
onlinePlayers = {}
return
end
while getOnlinePlayers do Citizen.Wait(100) end -- Wait for the xPlayer loop to finish
while getOnlinePlayers do Citizen.Wait(10) end -- Wait for the xPlayer loop to finish
cb(onlinePlayers)
end)