starred/Wand-Enhancer
1
0
Fork 0
mirror of https://github.com/k1tbyte/Wand-Enhancer.git synced 2026-08-28 17:01:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct TryKillProcess retry loop condition

Browse Source 
The loop "for (int i = 0; processes.Length > i || i < 5; i++)" compared the
process count to the loop index and, because of the "|| i < 5", always ran
at least 5 iterations of Thread.Sleep(250) -- stalling ~1.25s before every
patch/restore even when WeMod was not running.

Use "processes.Length > 0 && i < 5" so it retries only while a target
process is still alive, capped at 5 attempts.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
dchukkapalli-dev
2026-07-13 19:59:06 +00:00
parent 3b776c52fc
commit 7e8cadff24
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
WandEnhancer/Utils/Common.cs
+6 -1
View File
@@ -11,7 +11,12 @@ namespace WandEnhancer.Utils
public static void TryKillProcess(string processName)
{
Process[] processes = Process.GetProcessesByName(processName);
for (int i = 0; processes.Length > i || i < 5; i++)
// Retry while any target process is still alive, capped at 5 attempts.
// The previous condition (processes.Length > i || i < 5) compared the
// process count to the loop index and, because of the "|| i < 5", always
// ran at least 5 iterations — sleeping ~1.25s even when the process was
// never running.
for (int i = 0; processes.Length > 0 && i < 5; i++)
{
foreach (var process in processes)
{