Card-Collection-Manager-3-sebastiandine/tests/AGENTS.md

tests/AGENTS.md

ccm_core_tests — doctest unit tests for ccm_core. Hermetic, fast, no real network or disk. Read the root AGENTS.md first.

File pointers

• main.cpp — doctest entry point with DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN. Do not put tests here.
• fakes/InMemoryFileSystem.{hpp,cpp} — IFileSystem implementation backed by std::map. Normalizes paths via lexically_normal().generic_string() (always / separators).
• fs_names_tests.cpp — formatTextForFs + parseIndexFromFilename. Both are compatibility ports of the original Rust path rules.
• domain_json_tests.cpp — JSON round-trip tests for every domain type. Update this file whenever a domain type changes.
• image_service_tests.cpp — ImageService (uses inline RecordingImageStore fake).
• collection_service_tests.cpp — CollectionService<MagicCard> (uses inline InMemoryRepo + StubImageStore).
• config_service_tests.cpp — ConfigService against InMemoryFileSystem.
• json_collection_repository_tests.cpp, json_set_repository_tests.cpp — repository round-trips against InMemoryFileSystem.
• set_service_tests.cpp — SetService with FakeSetSource + InMemSetRepo.
• magic_set_source_tests.cpp — MagicSetSource::parseResponse (Scryfall mapping). Drives fetchAll via FixedHttpClient fake.
• magic_card_preview_source_tests.cpp — MagicCardPreviewSource::buildSearchUrl URL-encoding rules + parseResponse (data[0].image_uris.normal). Drives fetchImageUrl via FixedHttpClient.
• card_preview_service_tests.cpp — CardPreviewService registry/orchestration through registerModule(IGameModule&) with an inline FakeGameModule returning a FakeSource : ICardPreviewSource and a FixedHttpClient. Pin-down for the "module returning nullptr is silently skipped" rule.
• pokemon_set_source_tests.cpp — PokemonSetSource::parseResponse (api.pokemontcg.io/v2/sets shape — data[].id, name, releaseDate already in YYYY/MM/DD) + sort-by-release-date stability. Drives fetchAll via FixedHttpClient and asserts the public endpoint URL.
• pokemon_card_preview_source_tests.cpp — PokemonCardPreviewSource::buildSearchUrl (percent-encoded name: / set.id: / number: triple, with collector-number 4/102 -> 4 normalization) + parseResponse (data[0].images.large with images.small fallback). Drives fetchImageUrl via FixedHttpClient.
• card_sorter_tests.cpp — sortMagicCards / sortPokemonCards per-column behavior. Pin-down tests for byField-equivalent semantics: case-insensitive strings, chronological set sort via set.releaseDate, numeric amount, false < true boolean order, stable composition (sort by name then by set keeps inner-name order). Update this file whenever you add a new column / sort key.
• card_filter_tests.cpp — matchesMagicFilter / matchesPokemonFilter row-matcher behavior. Pin-down tests for applyFilter-equivalent semantics: case-insensitive substring match across tableFields valueKeys (name, set.name, language, condition, amount-as-string, note; Pokemon adds setNo), boolean flag columns (foil/signed/altered/holo/firstEdition) intentionally excluded, empty filter matches everything. Update this file whenever you add a new searchable column.
• CMakeLists.txt — explicit list of every .cpp (no glob).

Conventions

1. Framework: doctest. Each test file #include <doctest/doctest.h> and uses TEST_SUITE("...") + TEST_CASE("..."). Asserts: CHECK, REQUIRE, CHECK_THROWS.
2. No real I/O. Everything goes through ccm::testing::InMemoryFileSystem or an inline test-local fake. If you need HTTP, write a fake IHttpClient like FixedHttpClient in magic_set_source_tests.cpp.
3. Fakes for narrow concerns stay in the test file as anonymous-namespace classes (e.g. RecordingImageStore, InMemoryRepo). Promote a fake to tests/fakes/ only when more than one test file needs it.
4. Path strings in expectations must use forward slashes. The fake normalizes everything to generic_string(). Do not hard-code \ separators.
5. Test names describe behavior, not implementation. Prefer "missing file is created with defaults" over "test_init_no_file".
6. Add a .cpp to the add_executable call in tests/CMakeLists.txt. No glob.

Required follow-ups

• After modifying any domain type field or alias you must extend the matching test in domain_json_tests.cpp.
• After modifying formatTextForFs or parseIndexFromFilename you must extend fs_names_tests.cpp — these are byte-compatibility shims with the original Rust code.
• After adding a new service in core/ you must add a corresponding <name>_service_tests.cpp with at least the happy-path and one error-path test.
• After adding a new game's set source / card preview source you must add tests/<name>_set_source_tests.cpp and (if applicable) tests/<name>_card_preview_source_tests.cpp mirroring the Magic and Pokemon files. Add them to tests/CMakeLists.txt.

Commands

• Configure with tests on:
  cmake -S . -B build -DCCM_BUILD_TESTS=ON
• Build the suite:
  cmake --build build --target ccm_core_tests
• Run all tests:
  ctest --test-dir build --output-on-failure
• Run a single test by name pattern:
  ./build/bin/ccm_core_tests --test-case="*nextImageIndex*"
• Run a single suite:
  ./build/bin/ccm_core_tests --test-suite="MagicSetSource::parseResponse"

Anti-patterns

• Don't depend on ccm_ui_wx from tests. UI is out of scope here.
• Don't rely on file paths existing on the host (no /tmp, no C:\Users\...). Use InMemoryFileSystem.
• Don't add tests that require network access. The Pokemon stub test checks the message, not a real API call.