ENH - centralize phone defaults and fixed permissions (#26)

* ENH - centralize phone configuration defaults

* FIX - enforce fixed phone permissions

tests/framework_permissions.lua

@@ -0,0 +1,64 @@
+Config = {
+    Bridge = {
+        Framework = "qbox",
+    },
+    CommandPermissions = {
+        phonepanel = { "god", "superadmin", "admin" },
+    },
+}
+
+Bridge = {
+    Framework = {},
+}
+
+function GetResourceState(resource)
+    assert(resource == "qbx_core")
+    return "started"
+end
+
+function GetPlayers()
+    return { "1" }
+end
+
+local ace_permissions = {}
+local framework_permission = false
+
+function IsPlayerAceAllowed(source, permission)
+    assert(source == "1")
+    return ace_permissions[permission] == true
+end
+
+exports = {
+    qbx_core = {
+        GetPlayer = function(_, source)
+            if tonumber(source) ~= 1 then
+                return nil
+            end
+            return {
+                PlayerData = {
+                    citizenid = "test-citizen",
+                },
+            }
+        end,
+        HasGroup = function(_, source, groups)
+            assert(source == 1)
+            assert(groups == Config.CommandPermissions.phonepanel)
+            return framework_permission
+        end,
+    },
+}
+
+dofile("sky_phone/source/bridge/server/framework.lua")
+dofile("sky_phone/source/bridge/server/frameworks/qbox.lua")
+
+ace_permissions.admin = true
+assert(Bridge.Framework.HasPermission(1, "phonepanel"), "Qbox ACE permissions must grant access")
+
+ace_permissions.admin = false
+framework_permission = true
+assert(Bridge.Framework.HasPermission(1, "phonepanel"), "Qbox framework groups must remain supported")
+
+local success = pcall(Bridge.Framework.HasPermission, 1, "missing")
+assert(not success, "Missing fixed permission definitions must fail loudly")
+
+print("framework permission tests passed")

tests/inventory_bridges.lua

@@ -1,3 +1,9 @@
+local event_handlers = {}
+
+AddEventHandler = function(event_name, callback)
+    event_handlers[event_name] = callback
+end
+
 local function reset_bridge(inventory_name, unique_phones, sim_cards_enabled)
     Config = {
         Bridge = {
@@ -193,11 +199,18 @@ exports = {
 }
 load_inventory_contract("sky_phone/source/bridge/server/inventory/esx.lua")
 
-local ok, configuration_error = pcall(Bridge.Inventory.RegisterUsableItem, "phone", function()
-end)
-assert(not ok)
-assert(configuration_error:find("Config.Phone.Unique = false", 1, true))
-assert(configuration_error:find("Config.Sim.Enabled = false", 1, true))
+assert(Config.Phone.Unique == false)
+assert(Config.Sim.Enabled == false)
+assert(Bridge.Inventory.ConfigurationError == nil)
+
+Config.Phone.Unique = true
+Config.Sim.Enabled = true
+event_handlers["sky_phone:configurator:serverUpdated"]()
+assert(Config.Phone.Unique == false)
+assert(Config.Sim.Enabled == false)
+
+assert(Bridge.Inventory.RegisterUsableItem("phone", function()
+end))
 
 local manifest_file = assert(io.open("sky_phone/fxmanifest.lua", "rb"))
 local manifest = manifest_file:read("*a")

tests/inventory_extended_bridges.lua

@@ -1,3 +1,6 @@
+AddEventHandler = function()
+end
+
 local function reset_bridge(inventory_name, resource_name, inventory_export, framework_name, extra_exports)
     Config = {
         Bridge = { Inventory = inventory_name },

tests/server_phone_modules.lua

@@ -25,7 +25,7 @@ Bridge = {
     Debug = function()
     end,
     Framework = {
-        HasAdminGroup = function()
+        HasPermission = function()
             return true
         end,
     },
@@ -42,7 +42,6 @@ Bridge = {
 
 Config = {
     AdminPanel = {
-        AdminGroups = { "admin" },
         Command = "phoneadmin",
         Enabled = true,
     },