From 21913b585cd333fc6fc37af2beb68a173f9cf9b5 Mon Sep 17 00:00:00 2001 From: DerEchteAlec Date: Fri, 21 Aug 2026 18:14:39 +0200 Subject: [PATCH] FIX - use repository-native NUI build instructions (#22) Replace the unavailable workspace-only build_frontend.bat hint with the frontend pnpm commands shipped in the GitHub source tree. Link the pushed frontend development guide and keep the local-only script name out of the startup diagnostic through regression coverage. --- README.md | 2 +- sky_phone/source/server/nui_build_check.lua | 6 +++++- tests/nui_build_check.lua | 6 +++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7597172..7cbb9f7 100644 --- a/README.md +++ b/README.md @@ -650,7 +650,7 @@ pnpm build ### The resource starts but the phone UI is missing -- On startup, the server console prints `SKY PHONE UI BUILD IS MISSING OR INCOMPLETE` and lists the missing or invalid packaged files. +- On startup, the server console prints `SKY PHONE UI BUILD IS MISSING OR INCOMPLETE`, lists the missing or invalid packaged files, and shows repository-native build commands. - Install the latest published release package rather than GitHub's automatically generated source archive. - Confirm `sky_phone/source/html/index.html`, `assets`, `img`, and `sounds` exist. - Developers working from source must run the frontend production build before starting the resource. diff --git a/sky_phone/source/server/nui_build_check.lua b/sky_phone/source/server/nui_build_check.lua index 2ab7ab8..5b0fcc3 100644 --- a/sky_phone/source/server/nui_build_check.lua +++ b/sky_phone/source/server/nui_build_check.lua @@ -112,7 +112,11 @@ local function print_missing_nui_notice(missing_paths) lines[#lines + 1] = "" lines[#lines + 1] = "^3 Install the latest published release package, not GitHub's automatic source archive.^0" lines[#lines + 1] = "^5 Release: https://github.com/sky-systems/sky_phone/releases/latest^0" - lines[#lines + 1] = "^3 Developers working from source must run build_frontend.bat before starting sky_phone.^0" + lines[#lines + 1] = "^3 Developers working from source:^0" + lines[#lines + 1] = "^5 cd frontend^0" + lines[#lines + 1] = "^5 pnpm install --frozen-lockfile^0" + lines[#lines + 1] = "^5 pnpm build^0" + lines[#lines + 1] = "^5 Build guide: https://github.com/sky-systems/sky_phone#frontend-development^0" lines[#lines + 1] = ("^1%s^0"):format(border) print(table.concat(lines, "\n")) diff --git a/tests/nui_build_check.lua b/tests/nui_build_check.lua index 1c1834c..532a7ae 100644 --- a/tests/nui_build_check.lua +++ b/tests/nui_build_check.lua @@ -39,7 +39,11 @@ assert(missing_build_output:find("source/html/assets/*", 1, true)) assert(missing_build_output:find("source/html/img/custom-app.svg", 1, true)) assert(missing_build_output:find("source/html/sounds/button.mp3", 1, true)) assert(missing_build_output:find("not GitHub's automatic source archive", 1, true)) -assert(missing_build_output:find("build_frontend.bat", 1, true)) +assert(missing_build_output:find("cd frontend", 1, true)) +assert(missing_build_output:find("pnpm install --frozen-lockfile", 1, true)) +assert(missing_build_output:find("pnpm build", 1, true)) +assert(missing_build_output:find("https://github.com/sky-systems/sky_phone#frontend-development", 1, true)) +assert(not missing_build_output:find("build_frontend.bat", 1, true)) local missing_asset_files = {} for path, content in pairs(valid_files) do