From db11c7dcecae4567e486e7978daa9ca83a7bb99f Mon Sep 17 00:00:00 2001 From: TheiLLeniumStudios <104288623+TheiLLeniumStudios@users.noreply.github.com> Date: Wed, 4 May 2022 08:08:29 +0000 Subject: [PATCH] Fix linting issues --- client/drawtext.lua | 4 ++-- client/events.lua | 4 ++-- client/functions.lua | 6 +++--- client/loops.lua | 2 +- client/main.lua | 2 +- client/test_file.lua | 7 ------- server/commands.lua | 4 ++-- server/debug.lua | 2 +- server/events.lua | 16 ++++++++-------- server/functions.lua | 16 ++++++++-------- server/main.lua | 2 +- server/player.lua | 30 +++++++++++++++--------------- shared/items.lua | 2 +- shared/locale.lua | 3 +-- shared/main.lua | 2 +- shared/vehicles.lua | 2 +- shared/weapons.lua | 2 +- 17 files changed, 49 insertions(+), 57 deletions(-) delete mode 100644 client/test_file.lua diff --git a/client/drawtext.lua b/client/drawtext.lua index ef669b2..2f3280b 100644 --- a/client/drawtext.lua +++ b/client/drawtext.lua @@ -5,7 +5,7 @@ local function hideText() end local function drawText(text, position) - if not type(position) == "string" then position = "left" end + if type(position) ~= "string" then position = "left" end SendNUIMessage({ action = 'DRAW_TEXT', @@ -17,7 +17,7 @@ local function drawText(text, position) end local function changeText(text, position) - if not type(position) == "string" then position = "left" end + if type(position) ~= "string" then position = "left" end SendNUIMessage({ action = 'CHANGE_TEXT', diff --git a/client/events.lua b/client/events.lua index df2adec..6ed07e4 100644 --- a/client/events.lua +++ b/client/events.lua @@ -127,7 +127,7 @@ RegisterNetEvent('QBCore:Command:SpawnVehicle', function(vehName) Wait(0) end - if IsPedInAnyVehicle(ped) then + if IsPedInAnyVehicle(ped) then DeleteVehicle(veh) end @@ -147,7 +147,7 @@ RegisterNetEvent('QBCore:Command:DeleteVehicle', function() else local pcoords = GetEntityCoords(ped) local vehicles = GetGamePool('CVehicle') - for k, v in pairs(vehicles) do + for _, v in pairs(vehicles) do if #(pcoords - GetEntityCoords(v)) <= 5.0 then SetEntityAsMissionEntity(v, true, true) DeleteVehicle(v) diff --git a/client/functions.lua b/client/functions.lua index 75e937b..7e72c50 100644 --- a/client/functions.lua +++ b/client/functions.lua @@ -186,7 +186,7 @@ function QBCore.Functions.GetClosestPed(coords, ignoreList) else coords = GetEntityCoords(ped) end - local ignoreList = ignoreList or {} + ignoreList = ignoreList or {} local peds = QBCore.Functions.GetPeds(ignoreList) local closestDistance = -1 local closestPed = -1 @@ -407,12 +407,12 @@ function QBCore.Functions.GetVehicleProperties(vehicle) local colorPrimary, colorSecondary = GetVehicleColours(vehicle) if GetIsVehiclePrimaryColourCustom(vehicle) then - r, g, b = GetVehicleCustomPrimaryColour(vehicle) + local r, g, b = GetVehicleCustomPrimaryColour(vehicle) colorPrimary = {r, g, b} end if GetIsVehicleSecondaryColourCustom(vehicle) then - r, g, b = GetVehicleCustomSecondaryColour(vehicle) + local r, g, b = GetVehicleCustomSecondaryColour(vehicle) colorSecondary = {r, g, b} end diff --git a/client/loops.lua b/client/loops.lua index 62b0f5d..925e588 100644 --- a/client/loops.lua +++ b/client/loops.lua @@ -12,7 +12,7 @@ end) CreateThread(function() while true do if LocalPlayer.state.isLoggedIn then - if (QBCore.PlayerData.metadata['hunger'] <= 0 or QBCore.PlayerData.metadata['thirst'] <= 0) and not QBCore.PlayerData.metadata['isdead'] then + if (QBCore.PlayerData.metadata['hunger'] <= 0 or QBCore.PlayerData.metadata['thirst'] <= 0) and not QBCore.PlayerData.metadata['isdead'] then local ped = PlayerPedId() local currentHealth = GetEntityHealth(ped) local decreaseTreshold = math.random(5, 10) diff --git a/client/main.lua b/client/main.lua index efa365b..80f9157 100644 --- a/client/main.lua +++ b/client/main.lua @@ -10,4 +10,4 @@ end) -- To use this export in a script instead of manifest method -- Just put this line of code below at the very top of the script --- local QBCore = exports['qb-core']:GetCoreObject() \ No newline at end of file +-- local QBCore = exports['qb-core']:GetCoreObject() diff --git a/client/test_file.lua b/client/test_file.lua deleted file mode 100644 index 2c4c5c0..0000000 --- a/client/test_file.lua +++ /dev/null @@ -1,7 +0,0 @@ -print("Hello World") - -print(`I am a backtick string`) - -CreateThread(function() - while true do -end) diff --git a/server/commands.lua b/server/commands.lua index 125a1ea..e9aacf0 100644 --- a/server/commands.lua +++ b/server/commands.lua @@ -6,7 +6,7 @@ QBCore.Commands.IgnoreList = { -- Ignore old perm levels while keeping backwards } CreateThread(function() -- Add ace to node for perm checking - for k,v in pairs(QBConfig.Server.Permissions) do + for _, v in pairs(QBConfig.Server.Permissions) do ExecuteCommand(('add_ace qbcore.%s %s allow'):format(v, v)) end end) @@ -224,7 +224,7 @@ QBCore.Commands.Add('ooc', 'OOC Chat Message', {}, false, function(source, args) local Players = QBCore.Functions.GetPlayers() local Player = QBCore.Functions.GetPlayer(source) local playerCoords = GetEntityCoords(GetPlayerPed(source)) - for k, v in pairs(Players) do + for _, v in pairs(Players) do if v == source then TriggerClientEvent('chat:addMessage', v, { color = { 0, 0, 255}, diff --git a/server/debug.lua b/server/debug.lua index 7a8a9cf..9b4b3b2 100644 --- a/server/debug.lua +++ b/server/debug.lua @@ -42,4 +42,4 @@ end function QBCore.ShowSuccess(resource, msg) print('\x1b[32m['..resource..':LOG]\x1b[0m '..msg) -end \ No newline at end of file +end diff --git a/server/events.lua b/server/events.lua index 65d3268..78d2138 100644 --- a/server/events.lua +++ b/server/events.lua @@ -1,6 +1,6 @@ -- Event Handler -AddEventHandler('chatMessage', function(source, _, message) +AddEventHandler('chatMessage', function(_, _, message) if string.sub(message, 1, 1) == '/' then CancelEvent() return @@ -57,13 +57,13 @@ local function onPlayerConnecting(name, setKickReason, deferrals) deferrals.update(string.format(Lang:t('info.join_server'), name)) if not license then - deferrals.done(Lang:t('error.no_valid_license')) + deferrals.done(Lang:t('error.no_valid_license')) elseif isBanned then deferrals.done(Reason) elseif isLicenseAlreadyInUse and QBCore.Config.Server.CheckDuplicateLicense then deferrals.done(Lang:t('error.duplicate_license')) elseif isWhitelist and not whitelisted then - deferrals.done(Lang:t('error.not_whitelisted')) + deferrals.done(Lang:t('error.not_whitelisted')) else deferrals.done() if QBCore.Config.Server.UseConnectQueue then @@ -209,15 +209,15 @@ QBCore.Functions.CreateCallback('QBCore:HasItem', function(source, cb, items, am if not Player then return cb(false) end if type(items) == 'table' then local count = 0 - local finalcount = 0 + local finalcount for k, v in pairs(items) do if type(k) == 'string' then finalcount = 0 - for i, _ in pairs(items) do finalcount += 1 end + for _, _ in pairs(items) do finalcount = finalcount + 1 end local item = Player.Functions.GetItemByName(k) if item then if item.amount >= v then - count += 1 + count = count + 1 if count == finalcount then retval = true end @@ -229,13 +229,13 @@ QBCore.Functions.CreateCallback('QBCore:HasItem', function(source, cb, items, am if item then if amount then if item.amount >= amount then - count += 1 + count = count + 1 if count == finalcount then retval = true end end else - count += 1 + count = count + 1 if count == finalcount then retval = true end diff --git a/server/functions.lua b/server/functions.lua index 95b302d..fc55cb8 100644 --- a/server/functions.lua +++ b/server/functions.lua @@ -63,7 +63,7 @@ end function QBCore.Functions.GetPlayers() local sources = {} - for k, v in pairs(QBCore.Players) do + for k, _ in pairs(QBCore.Players) do sources[#sources+1] = k end return sources @@ -83,7 +83,7 @@ function QBCore.Functions.GetPlayersOnDuty(job) if Player.PlayerData.job.name == job then if Player.PlayerData.job.onduty then players[#players + 1] = src - count += 1 + count = count + 1 end end end @@ -96,7 +96,7 @@ function QBCore.Functions.GetDutyCount(job) for _, Player in pairs(QBCore.Players) do if Player.PlayerData.job.name == job then if Player.PlayerData.job.onduty then - count += 1 + count = count + 1 end end end @@ -137,7 +137,7 @@ end function QBCore.Functions.GetPlayersInBucket(bucket --[[ int ]]) local curr_bucket_pool = {} if QBCore.Player_Buckets and next(QBCore.Player_Buckets) then - for k, v in pairs(QBCore.Player_Buckets) do + for _, v in pairs(QBCore.Player_Buckets) do if v.bucket == bucket then curr_bucket_pool[#curr_bucket_pool + 1] = v.id end @@ -152,7 +152,7 @@ end function QBCore.Functions.GetEntitiesInBucket(bucket --[[ int ]]) local curr_bucket_pool = {} if QBCore.Entity_Buckets and next(QBCore.Entity_Buckets) then - for k, v in pairs(QBCore.Entity_Buckets) do + for _, v in pairs(QBCore.Entity_Buckets) do if v.bucket == bucket then curr_bucket_pool[#curr_bucket_pool + 1] = v.id end @@ -236,7 +236,7 @@ function QBCore.Functions.Kick(source, reason, setKickReason, deferrals) if source then DropPlayer(source, reason) end - for i = 0, 4 do + for _ = 0, 4 do while true do if source then if GetPlayerPing(source) >= 0 then @@ -279,7 +279,7 @@ function QBCore.Functions.RemovePermission(source, permission) QBCore.Commands.Refresh(src) end else - for k,v in pairs(QBCore.Config.Server.Permissions) do + for _, v in pairs(QBCore.Config.Server.Permissions) do if IsPlayerAceAllowed(src, v) then ExecuteCommand(('remove_principal identifier.%s qbcore.%s'):format(license, v)) QBCore.Commands.Refresh(src) @@ -299,7 +299,7 @@ end function QBCore.Functions.GetPermission(source) local src = source local perms = {} - for k,v in pairs (QBCore.Config.Server.Permissions) do + for _, v in pairs (QBCore.Config.Server.Permissions) do if IsPlayerAceAllowed(src, v) then perms[v] = true end diff --git a/server/main.lua b/server/main.lua index 41c0c43..722e84b 100644 --- a/server/main.lua +++ b/server/main.lua @@ -10,4 +10,4 @@ end) -- To use this export in a script instead of manifest method -- Just put this line of code below at the very top of the script --- local QBCore = exports['qb-core']:GetCoreObject() \ No newline at end of file +-- local QBCore = exports['qb-core']:GetCoreObject() diff --git a/server/player.lua b/server/player.lua index 0b873d4..1a6ae7f 100644 --- a/server/player.lua +++ b/server/player.lua @@ -238,9 +238,9 @@ function QBCore.Player.CreatePlayer(PlayerData) self.PlayerData.money[moneytype] = self.PlayerData.money[moneytype] + amount self.Functions.UpdatePlayerData() if amount > 100000 then - TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'AddMoney', 'lightgreen', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') added, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype], true) + TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'AddMoney', 'lightgreen', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') added, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype] .. ' reason: ' .. reason, true) else - TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'AddMoney', 'lightgreen', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') added, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype]) + TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'AddMoney', 'lightgreen', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') added, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype] .. ' reason: ' .. reason) end TriggerClientEvent('hud:client:OnMoneyChange', self.PlayerData.source, moneytype, amount, false) return true @@ -262,9 +262,9 @@ function QBCore.Player.CreatePlayer(PlayerData) self.PlayerData.money[moneytype] = self.PlayerData.money[moneytype] - amount self.Functions.UpdatePlayerData() if amount > 100000 then - TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'RemoveMoney', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') removed, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype], true) + TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'RemoveMoney', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') removed, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype] .. ' reason: ' .. reason, true) else - TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'RemoveMoney', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') removed, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype]) + TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'RemoveMoney', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') removed, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype] .. ' reason: ' .. reason) end TriggerClientEvent('hud:client:OnMoneyChange', self.PlayerData.source, moneytype, amount, true) if moneytype == 'bank' then @@ -281,7 +281,7 @@ function QBCore.Player.CreatePlayer(PlayerData) if not self.PlayerData.money[moneytype] then return false end self.PlayerData.money[moneytype] = amount self.Functions.UpdatePlayerData() - TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'SetMoney', 'green', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') set, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype]) + TriggerEvent('qb-log:server:CreateLog', 'playermoney', 'SetMoney', 'green', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** $' .. amount .. ' (' .. moneytype .. ') set, new ' .. moneytype .. ' balance: ' .. self.PlayerData.money[moneytype] .. ' reason: ' .. reason) return true end @@ -351,16 +351,16 @@ function QBCore.Player.CreatePlayer(PlayerData) local slots = QBCore.Player.GetSlotsByItem(self.PlayerData.items, item) local amountToRemove = amount if slots then - for _, slot in pairs(slots) do - if self.PlayerData.items[slot].amount > amountToRemove then - self.PlayerData.items[slot].amount = self.PlayerData.items[slot].amount - amountToRemove + for _, _slot in pairs(slots) do + if self.PlayerData.items[_slot].amount > amountToRemove then + self.PlayerData.items[_slot].amount = self.PlayerData.items[_slot].amount - amountToRemove self.Functions.UpdatePlayerData() - TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'RemoveItem', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** lost item: [slot:' .. slot .. '], itemname: ' .. self.PlayerData.items[slot].name .. ', removed amount: ' .. amount .. ', new total amount: ' .. self.PlayerData.items[slot].amount) + TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'RemoveItem', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** lost item: [slot:' .. _slot .. '], itemname: ' .. self.PlayerData.items[_slot].name .. ', removed amount: ' .. amount .. ', new total amount: ' .. self.PlayerData.items[_slot].amount) return true - elseif self.PlayerData.items[slot].amount == amountToRemove then - self.PlayerData.items[slot] = nil + elseif self.PlayerData.items[_slot].amount == amountToRemove then + self.PlayerData.items[_slot] = nil self.Functions.UpdatePlayerData() - TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'RemoveItem', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** lost item: [slot:' .. slot .. '], itemname: ' .. item .. ', removed amount: ' .. amount .. ', item removed') + TriggerEvent('qb-log:server:CreateLog', 'playerinventory', 'RemoveItem', 'red', '**' .. GetPlayerName(self.PlayerData.source) .. ' (citizenid: ' .. self.PlayerData.citizenid .. ' | id: ' .. self.PlayerData.source .. ')** lost item: [slot:' .. _slot .. '], itemname: ' .. item .. ', removed amount: ' .. amount .. ', item removed') return true end end @@ -494,8 +494,8 @@ function QBCore.Player.DeleteCharacter(source, citizenid) queries[i] = {query = query:format(v.table), values = { citizenid }} end - MySQL.Async.transaction(queries, function(result) - if result then + MySQL.Async.transaction(queries, function(result2) + if result2 then TriggerEvent('qb-log:server:CreateLog', 'joinleave', 'Character Deleted', 'red', '**' .. GetPlayerName(source) .. '** ' .. license .. ' deleted **' .. citizenid .. '**..') end end) @@ -577,7 +577,7 @@ function QBCore.Player.GetTotalWeight(items) local weight = 0 if not items then return 0 end for _, item in pairs(items) do - weight += item.weight * item.amount + weight = weight + item.weight * item.amount end return tonumber(weight) end diff --git a/shared/items.lua b/shared/items.lua index 546a0c2..d58cd32 100644 --- a/shared/items.lua +++ b/shared/items.lua @@ -244,7 +244,7 @@ QBShared.Items = { ['shotgun_ammo'] = {['name'] = 'shotgun_ammo', ['label'] = 'Shotgun ammo', ['weight'] = 500, ['type'] = 'item', ['image'] = 'shotgun_ammo.png', ['unique'] = false, ['useable'] = true, ['shouldClose'] = true, ['combinable'] = nil, ['description'] = 'Ammo for Shotguns'}, ['mg_ammo'] = {['name'] = 'mg_ammo', ['label'] = 'MG ammo', ['weight'] = 1000, ['type'] = 'item', ['image'] = 'mg_ammo.png', ['unique'] = false, ['useable'] = true, ['shouldClose'] = true, ['combinable'] = nil, ['description'] = 'Ammo for Machine Guns'}, ['snp_ammo'] = {['name'] = 'snp_ammo', ['label'] = 'Sniper ammo', ['weight'] = 1000, ['type'] = 'item', ['image'] = 'rifle_ammo.png', ['unique'] = false, ['useable'] = true, ['shouldClose'] = true, ['combinable'] = nil, ['description'] = 'Ammo for Sniper Rifles'}, - ['emp_ammo'] = {['name'] = 'emp_ammo', ['label'] = 'EMP Ammo', ['weight'] = 200, ['type'] = 'item', ['image'] = 'emp_ammo.png', ['unique'] = false, ['useable'] = true, ['shouldClose'] = true, ['combinable'] = nil, ['description'] = 'Ammo for EMP Launcher'}, + ['emp_ammo'] = {['name'] = 'emp_ammo', ['label'] = 'EMP Ammo', ['weight'] = 200, ['type'] = 'item', ['image'] = 'emp_ammo.png', ['unique'] = false, ['useable'] = true, ['shouldClose'] = true, ['combinable'] = nil, ['description'] = 'Ammo for EMP Launcher'}, -- Card ITEMS ['id_card'] = {['name'] = 'id_card', ['label'] = 'ID Card', ['weight'] = 0, ['type'] = 'item', ['image'] = 'id_card.png', ['unique'] = true, ['useable'] = true, ['shouldClose'] = false, ['combinable'] = nil, ['description'] = 'A card containing all your information to identify yourself'}, diff --git a/shared/locale.lua b/shared/locale.lua index eb7e462..6b9510b 100644 --- a/shared/locale.lua +++ b/shared/locale.lua @@ -31,7 +31,6 @@ end --- @param opts table - Constructor opts param --- @return Locale function Locale:new(opts) - local self = {} setmetatable(self, Locale) self.warnOnMissing = opts.warnOnMissing or true @@ -135,4 +134,4 @@ function Locale:delete(phraseTarget, prefix) end end end -end \ No newline at end of file +end diff --git a/shared/main.lua b/shared/main.lua index cace3c0..2319bc9 100644 --- a/shared/main.lua +++ b/shared/main.lua @@ -155,4 +155,4 @@ QBShared.FemaleNoGloves = { [157] = true, [161] = true, [165] = true -} \ No newline at end of file +} diff --git a/shared/vehicles.lua b/shared/vehicles.lua index cb7d8ce..79e9afc 100644 --- a/shared/vehicles.lua +++ b/shared/vehicles.lua @@ -4421,6 +4421,6 @@ QBShared.Vehicles = { }, } -for k,v in pairs(QBShared.Vehicles) do +for _, v in pairs(QBShared.Vehicles) do QBShared.VehicleHashes[v.hash] = v end diff --git a/shared/weapons.lua b/shared/weapons.lua index af0df12..148a40d 100644 --- a/shared/weapons.lua +++ b/shared/weapons.lua @@ -145,4 +145,4 @@ QBShared.Weapons = { -- Animals [`weapon_animal`] = {['name'] = 'weapon_animal', ['label'] = 'Animal', ['ammotype'] = nil, ['damagereason'] = 'Mauled'}, [`weapon_cougar`] = {['name'] = 'weapon_cougar', ['label'] = 'Cougar', ['ammotype'] = nil, ['damagereason'] = 'Mauled'}, -} \ No newline at end of file +}