Fix 5 instances of stripos('literal', ) where arguments were
reversed, causing the needle to be searched inside a short literal
instead of the literal inside the variable:
- Line 599: stripos('dlc', ) → stripos(, 'dlc') — DLC
branch was never entered for real game titles
- Line 601: stripos('Rock Band Network', ) → stripos(, ...)
— Rock Band check was dead code inside the dead DLC branch
- Line 603: strpos('-', ) → str_contains(, '-') — DLC
hyphen splitting never triggered
- Line 622: stripos('PSX2PSP', ) → stripos(, ...)
— worked by accident (PSX is prefix of PSX2PSP)
- Line 626: stripos('XBLA', ) + stripos('dlc', ) →
stripos(, ...) + stripos(, ...)
Also adds ConsoleServiceDlcParsingTest (9 tests) covering DLC title
parsing, Rock Band Network handling, hyphen splitting, and XBLA
platform upgrade.
Kcchouette
e5df723720