Update views and related controllers

2026-08-30 01:38:54 +00:00 · 2026-07-10 21:31:19 +02:00
parent 81d60db201
commit f6c18cdeac
40 changed files with 1303 additions and 1178 deletions
@@ -0,0 +1,101 @@
+<?php
+
+namespace Tests\Unit;
+
+use App\Http\Controllers\BasePageController;
+use App\Http\Controllers\SearchController;
+use Illuminate\Http\Request;
+use PHPUnit\Framework\TestCase;
+use ReflectionClass;
+
+class UserViewRequestInputTest extends TestCase
+{
+    public function test_page_resolution_rejects_non_scalar_and_negative_values(): void
+    {
+        $controller = $this->controller();
+
+        $this->assertSame(1, $controller->page(Request::create('/browse', 'GET', ['page' => ['2']])));
+        $this->assertSame(1, $controller->page(Request::create('/browse', 'GET', ['page' => -4])));
+        $this->assertSame(1, $controller->page(Request::create('/browse', 'GET', ['page' => '3.5'])));
+        $this->assertSame(3, $controller->page(Request::create('/browse', 'GET', ['page' => '3'])));
+    }
+
+    public function test_order_resolution_only_allows_known_sort_keys(): void
+    {
+        $controller = $this->controller();
+        $ordering = ['name_asc', 'postdate_desc'];
+
+        $this->assertSame('name_asc', $controller->order(Request::create('/browse', 'GET', ['ob' => 'name_asc']), $ordering));
+        $this->assertSame('', $controller->order(Request::create('/browse', 'GET', ['ob' => 'name_desc']), $ordering));
+        $this->assertSame('', $controller->order(Request::create('/browse', 'GET', ['ob' => ['name_asc']]), $ordering));
+    }
+
+    public function test_scalar_input_and_offset_helpers_normalize_user_query_values(): void
+    {
+        $controller = $this->controller();
+
+        $this->assertSame('', $controller->scalar(Request::create('/search', 'GET', ['title' => ['bad']]), 'title'));
+        $this->assertSame('ubuntu', $controller->scalar(Request::create('/search', 'GET', ['title' => 'ubuntu']), 'title'));
+        $this->assertSame(42, $controller->integer(Request::create('/browse', 'GET', ['t' => '42']), 't', 100));
+        $this->assertSame(100, $controller->integer(Request::create('/browse', 'GET', ['t' => '42.2']), 't', 100));
+        $this->assertSame(100, $controller->integer(Request::create('/browse', 'GET', ['t' => ['42']]), 't', 100));
+        $this->assertSame(['7010', '7020'], $controller->array(Request::create('/browse', 'GET', ['category' => ['7010', '7020']]), 'category'));
+        $this->assertSame([], $controller->array(Request::create('/browse', 'GET', ['category' => '7010']), 'category'));
+        $this->assertSame(80, $controller->offset(5, 20));
+    }
+
+    public function test_search_category_resolution_rejects_malformed_category_values(): void
+    {
+        $reflection = new ReflectionClass(SearchController::class);
+        $controller = $reflection->newInstanceWithoutConstructor();
+        $method = $reflection->getMethod('resolveCategoryIdsFromRequest');
+
+        $this->assertSame([1000, 2000], $method->invoke($controller, Request::create('/search', 'GET', ['t' => '1000,bad,2000,1000'])));
+        $this->assertSame([-1], $method->invoke($controller, Request::create('/search', 'GET', ['t' => ['1000']])));
+        $this->assertSame([-1], $method->invoke($controller, Request::create('/search', 'GET', ['searchadvcat' => ''])));
+    }
+
+    private function controller(): object
+    {
+        return new class extends BasePageController
+        {
+            public function __construct() {}
+
+            public function page(Request $request): int
+            {
+                return $this->resolvePage($request);
+            }
+
+            /**
+             * @param  array<int, string>  $ordering
+             */
+            public function order(Request $request, array $ordering): string
+            {
+                return $this->resolveOrderBy($request, $ordering);
+            }
+
+            public function scalar(Request $request, string $key): string
+            {
+                return $this->scalarInput($request, $key);
+            }
+
+            public function integer(Request $request, string $key, int $default): int
+            {
+                return $this->integerInput($request, $key, $default);
+            }
+
+            /**
+             * @return array<int|string, mixed>
+             */
+            public function array(Request $request, string $key): array
+            {
+                return $this->arrayInput($request, $key);
+            }
+
+            public function offset(int $page, int $perPage): int
+            {
+                return $this->paginationOffset($page, $perPage);
+            }
+        };
+    }
+}