From f26e97069732501dca2b6f941aadca82d3bd7ed3 Mon Sep 17 00:00:00 2001 From: DariusIII Date: Mon, 25 Aug 2025 21:51:21 +0200 Subject: [PATCH] Fix categories selectionwhen adding category regexes. Fixes #1770 --- .../Admin/AdminCategoryRegexesController.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/Http/Controllers/Admin/AdminCategoryRegexesController.php b/app/Http/Controllers/Admin/AdminCategoryRegexesController.php index 593c15d9d..3976c9d6b 100644 --- a/app/Http/Controllers/Admin/AdminCategoryRegexesController.php +++ b/app/Http/Controllers/Admin/AdminCategoryRegexesController.php @@ -109,15 +109,15 @@ class AdminCategoryRegexesController extends BasePageController ->whereNotNull('c.root_categories_id') ->orderBy('c.id') ->get(); - $categories = ['category_names', 'category_ids']; - if (count($categories_db) !== 0) { - foreach ($categories_db as $category_db) { - $categories['category_names'] = $category_db->parent_title.' '.$category_db->title.': '.$category_db->id; - $categories['category_ids'] = $category_db->id; - } + // Build arrays for Smarty html_options helper. Previously only last row was kept. + $category_ids = []; + $category_names = []; + foreach ($categories_db as $category_db) { + $category_ids[] = $category_db->id; + $category_names[] = $category_db->parent_title . ' ' . $category_db->title . ': ' . $category_db->id; } - $this->smarty->assign('category_names', $categories['category_names']); - $this->smarty->assign('category_ids', $categories['category_ids']); + $this->smarty->assign('category_names', $category_names); + $this->smarty->assign('category_ids', $category_ids); $content = $this->smarty->fetch('category_regexes-edit.tpl'); $this->smarty->assign(compact('title', 'meta_title', 'content'));