From efc28303c4e6053cd320c6e39ea27e3ca2410fe6 Mon Sep 17 00:00:00 2001 From: DariusIII Date: Wed, 14 Feb 2018 22:47:20 +0000 Subject: [PATCH] Apply fixes from StyleCI [ci skip] [skip ci] --- app/Extensions/util/Versions.php | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/app/Extensions/util/Versions.php b/app/Extensions/util/Versions.php index a8cfc06e3..e9a3dd9d1 100644 --- a/app/Extensions/util/Versions.php +++ b/app/Extensions/util/Versions.php @@ -145,17 +145,15 @@ class Versions extends Collection return $this->versions->git->tag; } // They're NOT the same but we were told not to update. - if ($options['verbose'] === true) { - echo "Current tag version $latestTag, skipping update!".PHP_EOL; - } - - return false; + if ($options['verbose'] === true) { + echo "Current tag version $latestTag, skipping update!".PHP_EOL; + } + return false; } // They're the same so return true - return true; - + return true; } /** @@ -355,9 +353,6 @@ class Versions extends Collection // TODO handle console error message. } - /** - * - */ protected function initialiseGit(): void { if (! ($this->git instanceof Git)) { @@ -375,7 +370,6 @@ class Versions extends Collection } /** - * * @throws \RuntimeException */ protected function loadXMLFile(): void @@ -399,16 +393,12 @@ class Versions extends Collection } $this->versions = &$this->xml->versions; // Create a convenience shortcut - } else { throw new \RuntimeException("No elements in file!\n"); } } } - /** - * - */ protected function _init(): void { if ($this->_config['git'] instanceof Git) {