From c898b4da4155fcb5e8afc300a2de5ce3e1ee4b36 Mon Sep 17 00:00:00 2001 From: DariusIII Date: Tue, 10 Mar 2026 11:16:36 +0100 Subject: [PATCH] Remove unused js code --- .../js/alpine/components/admin/features.js | 68 ------------------- .../AdminReleaseReportControllerTest.php | 18 +++++ 2 files changed, 18 insertions(+), 68 deletions(-) diff --git a/resources/js/alpine/components/admin/features.js b/resources/js/alpine/components/admin/features.js index ae83f8531..0082f49b3 100644 --- a/resources/js/alpine/components/admin/features.js +++ b/resources/js/alpine/components/admin/features.js @@ -458,51 +458,6 @@ Alpine.data('myMovies', () => ({ (function() { // --- Click delegation --- document.addEventListener('click', function(e) { - // Admin Release Reports: Description modal - var reportDescBtn = e.target.closest('.report-description-btn'); - if (reportDescBtn) { - e.preventDefault(); - var modal = document.getElementById('reportDescriptionModal'); - if (modal) { - document.getElementById('reportDescReason').textContent = reportDescBtn.dataset.reason || ''; - document.getElementById('reportDescReporter').textContent = reportDescBtn.dataset.reporter || ''; - document.getElementById('reportDescContent').textContent = reportDescBtn.dataset.description || ''; - modal.classList.remove('hidden'); - } - return; - } - - // Admin Release Reports: Close description modal - if (e.target.closest('.report-desc-modal-close') || e.target.closest('.report-desc-modal-backdrop')) { - e.preventDefault(); - var modal = document.getElementById('reportDescriptionModal'); - if (modal) modal.classList.add('hidden'); - return; - } - - // Admin Release Reports: Revert button - var revertBtn = e.target.closest('.revert-report-btn'); - if (revertBtn) { - e.preventDefault(); - var modal = document.getElementById('revertConfirmModal'); - var form = document.getElementById('revertConfirmForm'); - var statusSpan = document.getElementById('revertReportStatus'); - if (modal && form) { - form.action = revertBtn.dataset.actionUrl || ''; - if (statusSpan) statusSpan.textContent = revertBtn.dataset.reportStatus || ''; - modal.classList.remove('hidden'); - } - return; - } - - // Admin Release Reports: Close revert modal - if (e.target.closest('.revert-modal-close') || e.target.closest('.revert-modal-backdrop')) { - e.preventDefault(); - var modal = document.getElementById('revertConfirmModal'); - if (modal) modal.classList.add('hidden'); - return; - } - // Admin menu submenu toggle var menuToggle = e.target.closest('[data-toggle-submenu]'); if (menuToggle) { @@ -725,30 +680,7 @@ Alpine.data('myMovies', () => ({ }); }); - // --- Escape key for admin modals --- - document.addEventListener('keydown', function(e) { - if (e.key !== 'Escape') return; - var descModal = document.getElementById('reportDescriptionModal'); - if (descModal && !descModal.classList.contains('hidden')) descModal.classList.add('hidden'); - var revertModal = document.getElementById('revertConfirmModal'); - if (revertModal && !revertModal.classList.contains('hidden')) revertModal.classList.add('hidden'); - }); - // --- Admin select-alls and bulk forms --- - // Release reports select-all - var selectAllReports = document.getElementById('select-all'); - if (selectAllReports) { - var boxes = document.querySelectorAll('.report-checkbox'); - if (boxes.length > 0) { - selectAllReports.addEventListener('change', function() { boxes.forEach(function(cb) { cb.checked = selectAllReports.checked; }); }); - boxes.forEach(function(cb) { cb.addEventListener('change', function() { - var all = Array.from(boxes).every(function(c) { return c.checked; }); - var some = Array.from(boxes).some(function(c) { return c.checked; }); - selectAllReports.checked = all; selectAllReports.indeterminate = some && !all; - }); }); - } - } - // Invitations select-all var selectAllInv = document.getElementById('select_all'); if (selectAllInv) { diff --git a/tests/Feature/AdminReleaseReportControllerTest.php b/tests/Feature/AdminReleaseReportControllerTest.php index d06aea071..10b6ba824 100644 --- a/tests/Feature/AdminReleaseReportControllerTest.php +++ b/tests/Feature/AdminReleaseReportControllerTest.php @@ -109,6 +109,24 @@ class AdminReleaseReportControllerTest extends TestCase $this->assertStringContainsString('@click="showRevert(', $content); } + /** + * Test that legacy admin feature JS no longer handles release report modals. + */ + public function test_legacy_admin_features_js_no_longer_handles_release_reports(): void + { + $scriptPath = resource_path('js/alpine/components/admin/features.js'); + + $this->assertFileExists($scriptPath); + + $content = file_get_contents($scriptPath); + + $this->assertStringNotContainsString('reportDescriptionModal', $content); + $this->assertStringNotContainsString('revertConfirmModal', $content); + $this->assertStringNotContainsString('.report-checkbox', $content); + $this->assertStringNotContainsString('.report-description-btn', $content); + $this->assertStringNotContainsString('.revert-report-btn', $content); + } + /** * Test that bulk action dropdown includes revert option. */