From 937913cbf860d11c0d4db954bbedd810cda8cca1 Mon Sep 17 00:00:00 2001 From: DariusIII Date: Fri, 12 Jun 2026 10:16:12 +0200 Subject: [PATCH] CS fixes --- app/Http/Controllers/FailedReleasesController.php | 2 +- tests/Feature/FailedReleasesControllerSecurityTest.php | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/FailedReleasesController.php b/app/Http/Controllers/FailedReleasesController.php index ec32d1392..fd89b6b1c 100644 --- a/app/Http/Controllers/FailedReleasesController.php +++ b/app/Http/Controllers/FailedReleasesController.php @@ -15,7 +15,7 @@ class FailedReleasesController extends BasePageController { public function failed(Request $request): Application|Response|\Illuminate\Contracts\Foundation\Application|ResponseFactory { - if ($request->missing('guid')) { + if ($request->missing('guid')) { return response('Bad request, please supply all parameters!', 400)->withHeaders(['X-DNZB-RCode' => 400, 'X-DNZB-RText' => 'Bad request, please supply all parameters!']); } diff --git a/tests/Feature/FailedReleasesControllerSecurityTest.php b/tests/Feature/FailedReleasesControllerSecurityTest.php index 10d41438c..9de2d33e4 100644 --- a/tests/Feature/FailedReleasesControllerSecurityTest.php +++ b/tests/Feature/FailedReleasesControllerSecurityTest.php @@ -1,11 +1,15 @@ createSchema(); $this->seedSettings(); } + public function test_failed_callback_rejects_userid_without_session_or_api_token(): void { $this->createUser(1, 'rss-token'); @@ -33,6 +38,7 @@ class FailedReleasesControllerSecurityTest extends TestCase ]))->assertStatus(401) ->assertHeader('X-DNZB-RCode', 401); } + public function test_failed_callback_uses_api_token_user_and_preserves_token_for_alternate_download(): void { $this->createUser(1, 'rss-token'); @@ -63,6 +69,7 @@ class FailedReleasesControllerSecurityTest extends TestCase 'users_id' => 999, ]); } + private function createSchema(): void { Schema::create('settings', function (Blueprint $table): void { @@ -96,6 +103,7 @@ class FailedReleasesControllerSecurityTest extends TestCase $table->boolean('failed')->default(true); }); } + private function seedSettings(): void { DB::table('settings')->insert([ @@ -104,6 +112,7 @@ class FailedReleasesControllerSecurityTest extends TestCase ['name' => 'catwebdl', 'value' => '0'], ]); } + private function createUser(int $id, string $apiToken): void { DB::table('users')->insert([ @@ -119,6 +128,7 @@ class FailedReleasesControllerSecurityTest extends TestCase 'updated_at' => now(), ]); } + private function createRelease(int $id, string $guid, string $searchName, int $categoryId, string $postDate): void { DB::table('releases')->insert([