From 0fcdba4b77f4f2d93fec3df038d852147173a17c Mon Sep 17 00:00:00 2001 From: DariusIII Date: Thu, 6 Dec 2018 22:37:25 +0100 Subject: [PATCH] Update PPA class, change _createTempFolder function --- .../processing/post/ProcessAdditional.php | 17 +++++------------ Changelog | 1 + 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/Blacklight/processing/post/ProcessAdditional.php b/Blacklight/processing/post/ProcessAdditional.php index 522fee58f..054f1c03e 100755 --- a/Blacklight/processing/post/ProcessAdditional.php +++ b/Blacklight/processing/post/ProcessAdditional.php @@ -785,18 +785,13 @@ class ProcessAdditional * Create a temporary storage folder for the current release. * * @return bool - * @throws \RuntimeException */ protected function _createTempFolder(): bool { // Per release defaults. $this->tmpPath = $this->_mainTmpPath.$this->_release->guid.DS; if (! File::isDirectory($this->tmpPath)) { - if (! File::makeDirectory($this->tmpPath, 0777, true, true) && ! File::isDirectory($this->tmpPath)) { - throw new \RuntimeException(sprintf('Directory "%s" was not created', $this->tmpPath)); - } - - if (! File::isDirectory($this->tmpPath)) { + if (! File::makeDirectory($this->tmpPath, 0777, true, false) && ! File::isDirectory($this->tmpPath)) { $this->_echo('Unable to create directory: '.$this->tmpPath, 'warning'); return $this->_decrementPasswordStatus(); @@ -843,15 +838,13 @@ class ProcessAdditional /** * Decrement password status for the current release. * - * @param bool $return Return value. - * - * @return bool + * @return false */ - protected function _decrementPasswordStatus($return = false): bool + protected function _decrementPasswordStatus(): bool { - Release::query()->where('id', $this->_release->id)->decrement('passwordstatus'); + Release::whereId($this->_release->id)->decrement('passwordstatus'); - return $return; + return false; } /** diff --git a/Changelog b/Changelog index 58a130929..80a51dce9 100755 --- a/Changelog +++ b/Changelog @@ -1,4 +1,5 @@ 2018-12-07 DariusIII + * Chg: Update PPA class, change _createTempFolder function * Chg: Update symfony components to their latest versions * Chg: Update PPA class _rersivePathDelete function 2018-12-05 DariusIII