From de7dcb75bae8a759da14d336c93d5a123620397c Mon Sep 17 00:00:00 2001 From: Ilias Rbayti <63159154+Kenshiin13@users.noreply.github.com> Date: Wed, 20 Nov 2024 19:36:49 +0100 Subject: [PATCH 1/2] fix(esx_skin/client/modules/menu): clear old menu items before inserting new ones --- [core]/esx_skin/client/modules/menu.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/[core]/esx_skin/client/modules/menu.lua b/[core]/esx_skin/client/modules/menu.lua index e7ddcf1b..786a1b3b 100644 --- a/[core]/esx_skin/client/modules/menu.lua +++ b/[core]/esx_skin/client/modules/menu.lua @@ -37,7 +37,8 @@ end function Menu:InsertElements() local playerPed = PlayerPedId() - + + self.elements = {} for i = 1, #self.components, 1 do local value = self.components[i].value local componentId = self.components[i].componentId From d947633be8869d562eb86e23a536d2922d3b43aa Mon Sep 17 00:00:00 2001 From: Ilias Rbayti <63159154+Kenshiin13@users.noreply.github.com> Date: Wed, 20 Nov 2024 19:47:50 +0100 Subject: [PATCH 2/2] refactor(esx_skin/client/modules/menu): remove redundant check --- [core]/esx_skin/client/modules/menu.lua | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/[core]/esx_skin/client/modules/menu.lua b/[core]/esx_skin/client/modules/menu.lua index 786a1b3b..7af77cd6 100644 --- a/[core]/esx_skin/client/modules/menu.lua +++ b/[core]/esx_skin/client/modules/menu.lua @@ -37,7 +37,7 @@ end function Menu:InsertElements() local playerPed = PlayerPedId() - + self.elements = {} for i = 1, #self.components, 1 do local value = self.components[i].value @@ -52,9 +52,6 @@ function Menu:InsertElements() data.type = "slider" data.max = self.maxValues[self.components[i].name] - if not self.elements then - self.elements = {} - end self.elements[#self.elements + 1] = data end end