From 9829a13bf6e0337793546b6b1b900d33a79b3eeb Mon Sep 17 00:00:00 2001 From: Romain Lanz Date: Sat, 16 Sep 2017 21:42:32 +0200 Subject: [PATCH] fix(amount): cannot go in negative Before it was possible to depose or withdraw more money than possible --- server/main.lua | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/server/main.lua b/server/main.lua index 27198263..6fde1afd 100644 --- a/server/main.lua +++ b/server/main.lua @@ -10,11 +10,15 @@ AddEventHandler('esx_bankerjob:customerDeposit', function (target, amount) local xPlayer = ESX.GetPlayerFromId(target) TriggerEvent('esx_addonaccount:getSharedAccount', 'society_banker', function (account) - account.removeMoney(amount) - end) + if amount > 0 and account.money >= amount then + account.removeMoney(amount) - TriggerEvent('esx_addonaccount:getAccount', 'bank_savings', xPlayer.identifier, function (account) - account.addMoney(amount) + TriggerEvent('esx_addonaccount:getAccount', 'bank_savings', xPlayer.identifier, function (account) + account.addMoney(amount) + end) + else + TriggerClientEvent('esx:showNotification', xPlayer.source, _U('invalid_amount')) + end end) end) @@ -23,11 +27,15 @@ AddEventHandler('esx_bankerjob:customerWithdraw', function (target, amount) local xPlayer = ESX.GetPlayerFromId(target) TriggerEvent('esx_addonaccount:getAccount', 'bank_savings', xPlayer.identifier, function (account) - account.removeMoney(amount) - end) + if amount > 0 and account.money >= amount then + account.removeMoney(amount) - TriggerEvent('esx_addonaccount:getSharedAccount', 'society_banker', function (account) - account.addMoney(amount) + TriggerEvent('esx_addonaccount:getSharedAccount', 'society_banker', function (account) + account.addMoney(amount) + end) + else + TriggerClientEvent('esx:showNotification', xPlayer.source, _U('invalid_amount')) + end end) end)