From 12e6ddd99967f452edafe204aee80752bbe71dcf Mon Sep 17 00:00:00 2001 From: Mirow Date: Fri, 26 Jul 2024 22:13:16 +0200 Subject: [PATCH 1/3] fix(Notify): lua ls annotation typo --- [core]/esx_notify/Notify.lua | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/[core]/esx_notify/Notify.lua b/[core]/esx_notify/Notify.lua index d47066f8..cfb9ab97 100644 --- a/[core]/esx_notify/Notify.lua +++ b/[core]/esx_notify/Notify.lua @@ -1,6 +1,6 @@ local Debug = ESX.GetConfig().EnableDebug ----@param type string the notification type +---@param notificatonType string the notification type ---@param length number the length of the notification ---@param message any the message :D local function Notify(notificatonType, length, message) From 7e84f16f1e60f444c7b8fe8c097bdc68544fc88e Mon Sep 17 00:00:00 2001 From: Mirow Date: Fri, 26 Jul 2024 22:19:18 +0200 Subject: [PATCH 2/3] fix(Notify): fixed lint errors --- [core]/esx_notify/Notify.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/[core]/esx_notify/Notify.lua b/[core]/esx_notify/Notify.lua index cfb9ab97..5bddf2cc 100644 --- a/[core]/esx_notify/Notify.lua +++ b/[core]/esx_notify/Notify.lua @@ -36,6 +36,7 @@ RegisterNetEvent("ESX:Notify", Notify) if Debug then RegisterCommand("oldnotify", function() + ---@diagnostic disable-next-line ESX.ShowNotification("No Waypoint Set.", true, false, 140) end) From 959344e39f40e70e6b254e019bdc69140972c139 Mon Sep 17 00:00:00 2001 From: Mirow Date: Fri, 26 Jul 2024 22:19:28 +0200 Subject: [PATCH 3/3] refactor(client): used cached esx ped --- [core]/esx_progressbar/Progress.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/[core]/esx_progressbar/Progress.lua b/[core]/esx_progressbar/Progress.lua index e5994ef5..0f018f5f 100644 --- a/[core]/esx_progressbar/Progress.lua +++ b/[core]/esx_progressbar/Progress.lua @@ -16,7 +16,7 @@ local function Progressbar(message, length, Options) end end if CurrentProgress.FreezePlayer then - FreezeEntityPosition(PlayerPedId(), CurrentProgress.FreezePlayer) + FreezeEntityPosition(ESX.PlayerData.ped, CurrentProgress.FreezePlayer) end SendNUIMessage({ type = "Progressbar", @@ -30,7 +30,7 @@ local function Progressbar(message, length, Options) else ClearPedTasks(ESX.PlayerData.ped) if CurrentProgress.FreezePlayer then - FreezeEntityPosition(PlayerPedId(), false) + FreezeEntityPosition(ESX.PlayerData.ped, false) end if CurrentProgress.onFinish then CurrentProgress.onFinish() @@ -50,7 +50,7 @@ local function CancelProgressbar() }) ClearPedTasks(ESX.PlayerData.ped) if CurrentProgress.FreezePlayer then - FreezeEntityPosition(PlayerPedId(), false) + FreezeEntityPosition(ESX.PlayerData.ped, false) end if CurrentProgress.onCancel then CurrentProgress.onCancel()