mirror of
https://github.com/esx-framework/esx_core.git
synced 2026-08-29 05:02:15 +00:00
Selt
07b9253401
The processing thread counted the remaining time down in 1000 ms steps and read the global CurrentProgress on every wake, which caused two problems. Any duration that is not a whole number of seconds finished late, since the thread only checked after another full second. The NUI bar runs on wall clock time, so the bar completed and the player then stood frozen waiting for onFinish. Cancelling did not stop the thread either. CancelProgressbar clears CurrentProgress, but the sleeping thread only notices up to a second later, and if a new bar was started in that window it saw a non-nil CurrentProgress and kept decrementing the new one alongside its own thread. The new bar then finished at roughly half its length, firing onFinish early. The run now carries an id, so a thread stops as soon as its run is no longer the current one, and the end is an absolute timestamp rather than a countdown. Measured in game on artifact 25770, requested versus actual onFinish: before: 500 -> 1011, 4200 -> 5042, cancel then 3000 -> 1427 after: 500 -> 519, 4200 -> 4222, cancel then 3000 -> 3058
Use
- ESX Function
ESX.Progressbar("test", 25000,{
FreezePlayer = false,
animation ={
type = "anim",
dict = "mini@prostitutes@sexlow_veh",
lib ="low_car_sex_to_prop_p2_player"
},
onFinish = function()
--Code here
end})
- Export
exports["esx_progressbar"]:Progressbar("Unlocking Storage", 3000,{
FreezePlayer = true,
animation ={
type = "anim",
dict = "anim@mp_player_intmenu@key_fob@",
lib ="fob_click"
},
onFinish = function()
--Code here
end})
- Cancel
ESX.Progressbar("Unlocking Storage", 3000,{
FreezePlayer = true,
animation ={
type = "anim",
dict = "anim@mp_player_intmenu@key_fob@",
lib ="fob_click"
},
onFinish = function()
--Code here
end, onCancel = function()
--Code here
end
})
- Scenario
ESX.Progressbar("Unlocking Storage", 3000,{
FreezePlayer = true,
animation ={
type = "Scenario",
Scenario = "PROP_HUMAN_BUM_BIN",
},
onFinish = function()
--Code here
end, onCancel = function()
--Code here
end
})
Legal
esx_progressbar
Copyright (C) 2022-2024 ESX-Framework
This program Is free software: you can redistribute it And/Or modify it under the terms Of the GNU General Public License As published by the Free Software Foundation, either version 3 Of the License, Or (at your option) any later version.
This program Is distributed In the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty Of MERCHANTABILITY Or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License For more details.
You should have received a copy Of the GNU General Public License along with this program. If Not, see http://www.gnu.org/licenses/.