Minor code improvements

server/functions.lua

@@ -41,36 +41,36 @@ ESX.SavePlayer = function(xPlayer, cb)
 	xPlayer.setLastPosition(xPlayer.getCoords())
 
 	-- User accounts
-	for i=1, #xPlayer.accounts, 1 do
-		if ESX.LastPlayerData[xPlayer.source].accounts[xPlayer.accounts[i].name] ~= xPlayer.accounts[i].money then
+	for k,v in ipairs(xPlayer.accounts) do
+		if ESX.LastPlayerData[xPlayer.source].accounts[v.name] ~= v.money then
 			table.insert(asyncTasks, function(cb)
 				MySQL.Async.execute('UPDATE user_accounts SET money = @money WHERE identifier = @identifier AND name = @name', {
-					['@money']      = xPlayer.accounts[i].money,
+					['@money']      = v.money,
 					['@identifier'] = xPlayer.identifier,
-					['@name']       = xPlayer.accounts[i].name
+					['@name']       = v.name
 				}, function(rowsChanged)
 					cb()
 				end)
 			end)
 
-			ESX.LastPlayerData[xPlayer.source].accounts[xPlayer.accounts[i].name] = xPlayer.accounts[i].money
+			ESX.LastPlayerData[xPlayer.source].accounts[v.name] = v.money
 		end
 	end
 
 	-- Inventory items
-	for i=1, #xPlayer.inventory, 1 do
-		if ESX.LastPlayerData[xPlayer.source].items[xPlayer.inventory[i].name] ~= xPlayer.inventory[i].count then
+	for k,v in ipairs(xPlayer.inventory) do
+		if ESX.LastPlayerData[xPlayer.source].items[v.name] ~= v.count then
 			table.insert(asyncTasks, function(cb)
 				MySQL.Async.execute('UPDATE user_inventory SET count = @count WHERE identifier = @identifier AND item = @item', {
-					['@count']      = xPlayer.inventory[i].count,
+					['@count']      = v.count,
 					['@identifier'] = xPlayer.identifier,
-					['@item']       = xPlayer.inventory[i].name
+					['@item']       = v.name
 				}, function(rowsChanged)
 					cb()
 				end)
 			end)
 
-			ESX.LastPlayerData[xPlayer.source].items[xPlayer.inventory[i].name] = xPlayer.inventory[i].count
+			ESX.LastPlayerData[xPlayer.source].items[v.name] = v.count
 		end
 	end
 
@@ -135,7 +135,6 @@ ESX.GetPlayers = function()
 	return sources
 end
 
-
 ESX.GetPlayerFromId = function(source)
 	return ESX.Players[tonumber(source)]
 end