From 6f575f4cec4fe5872306812e09c9f79f559ed4c4 Mon Sep 17 00:00:00 2001 From: Sebastian Dine Date: Sat, 9 May 2026 15:28:54 +0200 Subject: [PATCH] fix: ci errors fixed (#7) * patch: trigger release * fix: ci fix * fix: ci fix --- .github/workflows/AGENTS.md | 1 + .github/workflows/feature-ci.yml | 2 ++ .github/workflows/master-ci.yml | 2 ++ README.md | 1 + 4 files changed, 6 insertions(+) diff --git a/.github/workflows/AGENTS.md b/.github/workflows/AGENTS.md index 6da7e05..b424f40 100644 --- a/.github/workflows/AGENTS.md +++ b/.github/workflows/AGENTS.md @@ -38,6 +38,7 @@ GitHub Actions workflows for CI, release automation, and policy checks. - Prefer minimal, surgical edits; avoid large workflow rewrites unless requested. - Reusable workflows should declare explicit `workflow_call` inputs for required context (e.g., version, merge SHA). - Sonar coverage steps that use `gcovr` must exclude third-party build trees at discovery time with `--exclude-directories` (for example `build/_deps`) so gcov does not process dependency `.gcda` files. +- For Linux Sonar coverage jobs, keep compiler and gcov toolchain aligned; because `cmake/Toolchain.cmake` prefers Clang by default, set `-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++` explicitly in the coverage configure step when using gcovr default `gcov`. - Keep `permissions` least-privilege: - reusable build workflows: `contents: read` - release/tag orchestrator: `contents: write` diff --git a/.github/workflows/feature-ci.yml b/.github/workflows/feature-ci.yml index 1ee20eb..f5fa25a 100644 --- a/.github/workflows/feature-ci.yml +++ b/.github/workflows/feature-ci.yml @@ -35,6 +35,8 @@ jobs: - name: Configure with coverage instrumentation run: > cmake -S . -B build -G Ninja + -DCMAKE_C_COMPILER=gcc + -DCMAKE_CXX_COMPILER=g++ -DCCM_BUILD_TESTS=ON -DCCM_USE_SYSTEM_WX=ON -DCMAKE_BUILD_TYPE=Debug diff --git a/.github/workflows/master-ci.yml b/.github/workflows/master-ci.yml index 551752a..e5b18b1 100644 --- a/.github/workflows/master-ci.yml +++ b/.github/workflows/master-ci.yml @@ -35,6 +35,8 @@ jobs: - name: Configure with coverage instrumentation run: > cmake -S . -B build -G Ninja + -DCMAKE_C_COMPILER=gcc + -DCMAKE_CXX_COMPILER=g++ -DCCM_BUILD_TESTS=ON -DCCM_USE_SYSTEM_WX=ON -DCMAKE_BUILD_TYPE=Debug diff --git a/README.md b/README.md index 340ef5d..7248f37 100644 --- a/README.md +++ b/README.md @@ -70,3 +70,4 @@ This project continues earlier versions of Card Collection Manager: This project is licensed under the [MIT License](LICENSE). Third-party dependencies and assets remain under their respective licenses. +