From e4b8d423ee92da2b0e0f363cec084797e3090e35 Mon Sep 17 00:00:00 2001
From: Louis Lam <louislam@users.noreply.github.com>
Date: Thu, 19 Feb 2026 13:29:04 +0800
Subject: [PATCH] fix: rdap data is not actually used (#6981)

---
 server/model/domain_expiry.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/server/model/domain_expiry.js b/server/model/domain_expiry.js
index 73fc020b..fafcffa2 100644
--- a/server/model/domain_expiry.js
+++ b/server/model/domain_expiry.js
@@ -42,8 +42,6 @@ async function getRdapDnsData() {
         return cacheRdapDnsData;
     }
 
-    let data = null;
-
     // Avoid multiple simultaneous updates
     // Use older data first if another update is in progress
     if (running) {
@@ -58,27 +56,29 @@ async function getRdapDnsData() {
             throw new Error(`HTTP error: ${response.status}`);
         }
 
-        data = await response.json();
+        const data = await response.json();
 
         // Simple validation
         if (!data.services || !Array.isArray(data.services)) {
             throw new Error("Invalid RDAP DNS data structure");
         }
 
+        cacheRdapDnsData = data;
+
         // Next week
         nextChecking = Date.now() + 7 * 24 * 60 * 60 * 1000;
         await Settings.set("rdapDnsData", data);
         log.info("rdap", "RDAP DNS data updated successfully. Number of services: " + data.services.length);
     } catch (error) {
         log.info("rdap", `Uable to update RDAP DNS data from source: ${error.message}`);
-        data = await getOfflineRdapDnsData();
+        cacheRdapDnsData = await getOfflineRdapDnsData();
 
         // Check again next day
         nextChecking = Date.now() + 24 * 60 * 60 * 1000;
     }
 
     running = false;
-    return data;
+    return cacheRdapDnsData;
 }
 
 /**